Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload roomview on offline connectivity check #29243

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Don't reload roomview on offline connectivity check #29243

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70a80fe
Don't reload roomview on offline connectivity check
dbkr Feb 11, 2025
c823861
Add regression test
dbkr Feb 11, 2025
0711cf0
Move it down the file to avoid changing the snapshots
dbkr Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/structures/RoomView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,13 +1151,14 @@ export class RoomView extends React.Component<IRoomProps, IRoomState> {
break;
case "MatrixActions.sync":
if (!this.state.matrixClientIsReady) {
const isReadyNow = Boolean(this.context.client?.isInitialSyncComplete());
this.setState(
{
matrixClientIsReady: !!this.context.client?.isInitialSyncComplete(),
matrixClientIsReady: isReadyNow,
},
() => {
// send another "initial" RVS update to trigger peeking if needed
this.onRoomViewStoreUpdate(true);
if (isReadyNow) this.onRoomViewStoreUpdate(true);
},
);
}
Expand Down
Loading