Make CallHandler more EventEmittery
#18823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/call-handler-emittery
branch
from
54ac9ac to
b7ff595
Compare
|
Closing as using the |
SimonBrandner
added a commit
to SimonBrandner/matrix-react-sdk
that referenced
this pull request
Sep 11, 2021
Signed-off-by: Šimon Brandner <[email protected]>
dbkr
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Nov 30, 2021
* sharedInstance() -> instance Signed-off-by: Šimon Brandner <[email protected]> * Use CallState event instead of dispatching Signed-off-by: Šimon Brandner <[email protected]> * Simplifie some code Signed-off-by: Šimon Brandner <[email protected]> * Use a method to start a call instead of the dispatcher Signed-off-by: Šimon Brandner <[email protected]> * Use a method instead of place_conference_call Signed-off-by: Šimon Brandner <[email protected]> * Make terminateCallApp() and hangupCallApp() public Signed-off-by: Šimon Brandner <[email protected]> * Use hangupAllCalls() instead of the dispatcher Signed-off-by: Šimon Brandner <[email protected]> * Make dialNumber(), startTransferToMatrixID() and startTransferToPhoneNumber() public instead of using the dispatcher Signed-off-by: Šimon Brandner <[email protected]> * Use answerCall() instead of using the dispatcher Signed-off-by: Šimon Brandner <[email protected]> * Use hangupOrReject() instead of the dispatcher Signed-off-by: Šimon Brandner <[email protected]> * Update docs Signed-off-by: Šimon Brandner <[email protected]> * Improve TS Signed-off-by: Šimon Brandner <[email protected]> * Dispatch call_state, see element-hq/element-web#18823 (comment) Signed-off-by: Šimon Brandner <[email protected]> * Add missing import Signed-off-by: Šimon Brandner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#6704
Type: task
This change is marked as an internal change (Task), so will not be included in the changelog.