Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions: Send reaction event when user reacts #9572

Closed
jryans opened this issue Apr 26, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#2954
Closed

Reactions: Send reaction event when user reacts #9572

jryans opened this issue Apr 26, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#2954
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 26, 2019 •
edited
Loading

Reaction events are sent in response to 2 UI actions:

  • Choosing a new emoji type from the picker
  • Clicking on an existing type displayed below a message to increment an existing type
@jryans jryans changed the title Reactions: Send reaction event when user clicks emoji Reactions: Send reaction event when user reacts Apr 26, 2019
This was referenced Apr 29, 2019
Closed
Closed
@jryans jryans self-assigned this May 9, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 10, 2019
@jryans
Add Event.relationsCreated event to listen for future relations col…
6ac3b20 
…lections

If you ask for relations but none currently exist, we return `null` to avoid the
overhead of many empty relations objects in memory. However, we still want some
way to alert consumers when one _is_ later made, so this event level event
provides that.

Part of element-hq/element-web#9572
Part of element-hq/element-web#9485
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 10, 2019
@jryans
Add Relations.add event for additional relations in collection
e1b6aaf 
This adds a `Relations.add` event that consumers can listen for to be notified
each time an additional relation event is added to a relations collection.

Part of element-hq/element-web#9485
Part of element-hq/element-web#9572
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 10, 2019
@jryans
Listen for additional reactions in existing collection
39bd0d8 
The various reaction UI bits will now listen for `Reactions.add` for new
reactions just like with redactions.

Part of element-hq/element-web#9572
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 10, 2019
@jryans
Send and redact reaction events
dc4fccd 
This updates both the reaction row and action bar UIs to send and redact
reaction events as appropriate based on user interactions.

Fixes element-hq/element-web#9574
Fixes element-hq/element-web#9572
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 10, 2019
@jryans
Add Event.relationsCreated event to listen for future relations col…
8c59977 
…lections

If you ask for relations but none currently exist, we return `null` to avoid the
overhead of many empty relations objects in memory. However, we still want some
way to alert consumers when one _is_ later made, so this event level event
provides that.

Part of element-hq/element-web#9572
Part of element-hq/element-web#9485
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 10, 2019
@jryans
Add Relations.add event for additional relations in collection
412edcd 
This adds a `Relations.add` event that consumers can listen for to be notified
each time an additional relation event is added to a relations collection.

Part of element-hq/element-web#9485
Part of element-hq/element-web#9572
This was referenced May 10, 2019
Merged
Merged
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 13, 2019
@jryans
Add Event.relationsCreated event to listen for future relations col…
7ea820f 
…lections

If you ask for relations but none currently exist, we return `null` to avoid the
overhead of many empty relations objects in memory. However, we still want some
way to alert consumers when one _is_ later made, so this event level event
provides that.

Part of element-hq/element-web#9572
Part of element-hq/element-web#9485
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 13, 2019
@jryans
Add Relations.add event for additional relations in collection
4b4ba86 
This adds a `Relations.add` event that consumers can listen for to be notified
each time an additional relation event is added to a relations collection.

Part of element-hq/element-web#9485
Part of element-hq/element-web#9572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send and undo reaction events matrix-org/matrix-react-sdk
2 participants
@jryans @lampholder