Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifier blocks load when push rules haven't loaded #9323

Closed
jryans opened this issue Mar 29, 2019 · 1 comment
Closed

Notifier blocks load when push rules haven't loaded #9323

jryans opened this issue Mar 29, 2019 · 1 comment
Assignees
@jryans
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 29, 2019

https://github.com/matrix-org/riot-web-rageshakes/issues/1336
https://github.com/matrix-org/riot-web-rageshakes/issues/1337
@jryans jryans self-assigned this Mar 29, 2019
@jryans jryans added the S-Critical Prevents work, causes data loss and/or has no workaround label Mar 29, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 29, 2019
@jryans
Delay Notifier check until we have push rules
6e79cbc 
The `Notifier` class expects push rules to be available, so it can explode in
strange ways if called too early. This changes to wait until the sync is in the
`PREPARED` state (when push rules should be ready) before using the `Notifier`.

Fixes element-hq/element-web#9323
@jryans jryans mentioned this issue Mar 29, 2019
Merged
@jryans
Copy link
Collaborator Author

jryans commented Mar 29, 2019

This regression appeared after matrix-org/matrix-react-sdk#2842 merged which happened to use Notifier earlier than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jryans