Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should use typing everywhere for declarations #8923

Closed
turt2live opened this issue Feb 25, 2019 · 2 comments
Closed

We should use typing everywhere for declarations #8923

turt2live opened this issue Feb 25, 2019 · 2 comments
Labels
T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

instead of function test(arg) we should use function test(arg: string): boolean
@turt2live turt2live added the T-Task Tasks for the team like planning label Feb 25, 2019
@turt2live
Copy link
Member Author

ftr this is in prep for typescript

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 27, 2019
@turt2live
Track the user's own typing state external to the composer
cd089a3 
Fixes element-hq/element-web#9986

There's a few reasons for pushing this out to its own place:
* In future, we might want to move WhoIsTyping here.
* We have multiple composers now, and although they don't send typing notifications, they could (see https://github.com/vector-im/riot-web/issues/10188)
* In future we may have status for where/what the user is typing (https://github.com/matrix-org/matrix-doc/issues/437)
* The composer is complicated enough - it doesn't need to dedupe typing states too.

Note: This makes use of the principles introduced in element-hq/element-web#8923 and element-hq/element-web#9090
@turt2live turt2live mentioned this issue Jun 27, 2019
Merged
@turt2live
Copy link
Member Author

we're transitioning to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live