Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomView completely reloads every few seconds when offline #29072

Closed
ara4n opened this issue Jan 22, 2025 · 2 comments · Fixed by #29243
Closed

RoomView completely reloads every few seconds when offline #29072

ara4n opened this issue Jan 22, 2025 · 2 comments · Fixed by #29243
Labels
A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Jan 22, 2025

Steps to reproduce

  1. Open a room
  2. Drop your network connection (perhaps after sending a few queued msgs)
  3. Sit watching the current RoomView spasm every few seconds, entirely reloading itself.
  4. Wince as this looks super ugly and makes it hard to use the app offline.

Outcome

What did you expect?

The app shouldn't spasm in agony when it can't connect to the server.

What happened instead?

A regression. I first noticed it about 3-4 days ago.

Operating system

macOS

Application version

Element Nightly version: 2025012201 Crypto version: Rust SDK 0.8.0 (21f7cc7), Vodozemac 0.8.1

How did you install the app?

No response

Homeserver

matrix.org

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Jan 22, 2025
@dosubot dosubot bot added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-View labels Jan 22, 2025
@MidhunSureshR MidhunSureshR added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 23, 2025
@ara4n
Copy link
Member Author

ara4n commented Jan 30, 2025

this is really painful when trying to work offline.

1 similar comment
@ara4n
Copy link
Member Author

ara4n commented Jan 30, 2025

this is really painful when trying to work offline.

dbkr added a commit that referenced this issue Feb 11, 2025
@dbkr
Don't reload roomview on offline connectivity check
70a80fe 
Doesn't look like this was a regression as far as I can see, but
you did have to switch rooms while offline for it to start happening.

There's no use reloading the room until we're online again.

Fixes #29072
@dbkr dbkr mentioned this issue Feb 11, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 11, 2025
@dbkr
Don't reload roomview on offline connectivity check (#29243)
53c97df 
* Don't reload roomview on offline connectivity check

Doesn't look like this was a regression as far as I can see, but
you did have to switch rooms while offline for it to start happening.

There's no use reloading the room until we're online again.

Fixes #29072

* Add regression test

* Move it down the file to avoid changing the snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-View O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't reload roomview on offline connectivity check element-hq/element-web
2 participants
@ara4n @MidhunSureshR