Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll editing and undisclosed polls #5378

Merged
merged 9 commits into from
Jan 18, 2022
Merged

Poll editing and undisclosed polls #5378

merged 9 commits into from
Jan 18, 2022

Conversation

stefanceriu
Copy link
Member

  • enabled editing polls before they receive any responses
  • added option to create and render undisclosed polls

How it looks like:

Screenshot 2022-01-13 at 17 31 42

Screenshot 2022-01-13 at 17 34 15

Screenshot 2022-01-13 at 17 34 19

Screenshot 2022-01-13 at 17 34 23

@stefanceriu stefanceriu requested a review from gaelledel January 13, 2022 15:36
@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/c3P6b9

@turt2live turt2live mentioned this pull request Jan 14, 2022
Merged
pixlwave
pixlwave reviewed Jan 14, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline. Looks great!
PollTimeline -> TimelinePoll = 😎

RiotSwiftUI/Modules/Room/LocationSharing/LocationSharingScreenState.swift Show resolved Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/PollEditFormScreenState.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/PollEditFormViewModel.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/Test/Unit/PollEditFormViewModelTests.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/PollEditFormModels.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/TimelinePoll/Coordinator/TimelinePollCoordinator.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/TimelinePoll/TimelinePollModels.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/TimelinePoll/View/TimelinePollAnswerOptionButton.swift Outdated Show resolved Hide resolved
Riot/Generated/Images.swift
Comment on lines +158 to +159
internal static let pollTypeCheckboxDefault = ImageAsset(name: "poll_type_checkbox_default")
internal static let pollTypeCheckboxSelected = ImageAsset(name: "poll_type_checkbox_selected")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheeky suggestion, if we were to use circle and record.circle/smallcircle.fill.circle SF symbols instead of custom assets, then they would scale perfectly with dynamic type 😉

Probably a suggestion for @gaelledel rather than you though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that would be great but they don't quite match our designs.

Screenshot 2022-01-14 at 16 21 15

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference these two as well, but yeah, that's sad :(
Screenshot 2022-01-14 at 4 01 37 pm
Screenshot 2022-01-14 at 4 00 59 pm

RiotSwiftUI/Modules/Room/TimelinePoll/Coordinator/TimelinePollCoordinator.swift Show resolved Hide resolved
@stefanceriu stefanceriu requested a review from pixlwave January 17, 2022 09:47
pixlwave
pixlwave approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📊

@stefanceriu stefanceriu merged commit d131cc9 into develop Jan 18, 2022
@stefanceriu stefanceriu deleted the stefan/poll-editing branch January 18, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@gaelledel gaelledel Awaiting requested review from gaelledel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave