-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polls in the timeline #5202
Polls in the timeline #5202
Conversation
stefanceriu
commented
Nov 26, 2021
- Added support for rendering polls in the timeline.
- Introduced new poll bubble cells that render a SwiftUI component on the existing timeline.
- Integrated the already existing poll builder and aggregator into the PollTimeline coordinator
- Added polls labs setting
- increased edit form texts max length
- linked creation form to poll start events
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ndweSQ |
@stefanceriu The build has expired :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I triggered a new one, can you try again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Sorry for number of comments (I seem to always say this 🙄). 2 larger comments:
- More doc comments please 🥺
- With the
PollTimelineProvider
being a singleton, what happens when you push another room on top of the existing room and then navigate back (e.g. for a preview or a thread)?
RiotSwiftUI/Modules/Room/PollEditForm/Coordinator/PollEditFormCoordinator.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/Coordinator/PollEditFormCoordinator.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollTimeline/Coordinator/PollTimelineCoordinator.swift
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RiotSwiftUI/Modules/Room/PollTimeline/Coordinator/PollTimelineCoordinator.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollTimeline/View/PollTimelineAnswerOptionButton.swift
Outdated
Show resolved
Hide resolved
dc62af5
to
1c919db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thank you for the changes! :)
RiotSwiftUI/Modules/Room/PollTimeline/PollTimelineViewModel.swift
Outdated
Show resolved
Hide resolved
204e098
to
91108e2
Compare