New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest version of Lint (8.0.0-alpha10) #7891

Merged

mnaturel merged 2 commits into develop from fix/mna/false-positives

Jan 4, 2023

Contributor

mnaturel commented Jan 4, 2023

Type of change

Feature
Bugfix
Technical
Other :

Content

Using gradle flag to set lint version to a more recent one than the one bundled with AGP version.

Motivation and context

With the current version (7.3.1) there are many false positives reported by Lint.

Screenshots / GIFs

N/A

Tests

Run ./gradlew vector-app:lintGplayRelease
Check there are no errors reported by the analysis

Tested devices

N/A

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

mnaturel added 2 commits

January 4, 2023 14:56


          Use latest version of lint

0d5b6ef


          Fix error reported for usage of some methods from API 33

36b1c12

mnaturel marked this pull request as ready for review

January 4, 2023 14:13

mnaturel requested a review from bmarty

January 4, 2023 14:13

ElementBot commented Jan 4, 2023

	Warnings
⚠️	Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 36b1c12

mnaturel mentioned this pull request

Fix lint false positive #7885

Merged

bmarty approved these changes

View reviewed changes

Member

bmarty left a comment

Thanks !

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

mnaturel merged commit 87928b4 into develop

mnaturel deleted the fix/mna/false-positives branch

January 4, 2023 15:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet