feat: Make --keychain option optional #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there exists an iCloud keychain, notarytool by default uses that. The iCloud keychain does not have a local path, and thus cannot be specified explicitly using --keychain, only implicitly using no --keychain argument. Make the opts.keychain argument optional, to allow this (common) behavior.
jwatte
changed the title
jwatte
changed the title
This was referenced Dec 23, 2021
|
I experience the same problem. Do you have plans to merge this? |
MarshallOfSound
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there exists an iCloud keychain, notarytool by default uses that.
The iCloud keychain does not have a local path, and thus cannot be
specified explicitly using --keychain, only implicitly using no
--keychain argument.
Make the opts.keychain argument optional, to allow this (common)
behavior.