-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to node-webkit target. #34
Conversation
LGTM! |
@saboya Thanks for adding this 👍 @ralphtheninja wouldn't this be a breaking change for prebuild since this PR modifies Is this behavior change in behavior desired? If so we should do a new major release, else I would recommend adding node-webkit to something like |
Moving to |
@lgeiger Maybe should have a discussion on what is ok for default behavior of |
|
move node-webkit to additionalTargets + export additionalTargets
@saboya @ralphtheninja Thanks for your work! This is released under 2.2.0 |
This PR adds support to node-webkit target, necessary to build native modules when using NW.js, an Electron alternative.
Tests are included.
NW.js apparently does not follow a specific versioning pattern to switch ABI, so the
getNextTarget
function can't be implemented correctly fornode-webkit
, so I left it untouched.