Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-vite): make --force flag work #3825

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(template-vite): make --force flag work #3825

merged 1 commit into from
Jan 29, 2025

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jan 29, 2025

Fixes #3783

We were calling fs.moveSync(src, dest) from the template code, but this function fails if dest already exists without passing the overwrite flag.

To fix this, we align the overwrite flag with the value of --force being passed into the init command.

@erickzhao erickzhao requested a review from a team as a code owner January 29, 2025 06:02
@erickzhao erickzhao added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@erickzhao erickzhao added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit f084010 Jan 29, 2025
15 checks passed
@erickzhao erickzhao deleted the fix/force-vite branch January 29, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--force flag doesn't work with Vite template
2 participants