Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing dict.SetHidden("simple", true); for @electron/remote #39483

Closed
wants to merge 1 commit into from
Closed

fix: add missing dict.SetHidden("simple", true); for @electron/remote #39483

wants to merge 1 commit into from

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 12, 2023

Description of Change

Checklist

Release Notes

Notes:

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 12, 2023
@miniak miniak force-pushed the miniak/remote-module-simple-objects branch from 0e6f038 to e3436e2 Compare August 12, 2023 23:08
@miniak miniak added the wip ⚒ label Aug 12, 2023
@miniak miniak self-assigned this Aug 12, 2023
MarshallOfSound
MarshallOfSound requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were removing all remote related code from e/e, why does this have to come back?

@miniak
Copy link
Contributor Author

miniak commented Aug 13, 2023

@MarshallOfSound there are currently 20 instances of dict.SetHidden("simple", true); in the code. So we should either remove all of them and detect simple objects in @electron/remote without this hint. Or add the missing ones. I am leaning towards the first option then.

@miniak miniak force-pushed the miniak/remote-module-simple-objects branch from e3436e2 to 8f4cf13 Compare August 14, 2023 09:31
@miniak miniak closed this Aug 16, 2023
@miniak
Copy link
Contributor Author

miniak commented Aug 16, 2023

Doing #39486 instead

@miniak miniak deleted the miniak/remote-module-simple-objects branch August 16, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound requested changes

Assignees

@miniak miniak

Labels
new-pr 🌱 PR opened in the last 24 hours wip ⚒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miniak @MarshallOfSound