build: bake node v18.12.1 Appveyor image #37250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
fast-track 🚅
jkleinsc
requested changes
Feb 13, 2023
jkleinsc
approved these changes
Feb 13, 2023
|
No Release Notes |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: bake a new AppVeyor image * build: use image e-111.0.5560.0-4 * build: remove nodejs-lts * build: use new baked image
gecko19
pushed a commit
to brightsign/electron
that referenced
this pull request
Feb 28, 2023
* chore: bake a new AppVeyor image * build: use image e-111.0.5560.0-4 * build: remove nodejs-lts * build: use new baked image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Recent Node patches have introduced a bug where uploading artifacts will hit this Node bug: nodejs/node#46221
This PR bakes a new image that uses Node v18.12.1, to avoid this bug while we find a solution to the duplex error.
Checklist
npm testpassesRelease Notes
Notes: none