chore: enhance logging of PR numbers

electron · Feb 5, 2025 · 5ca9b27 · 5ca9b27
1 parent 616624e
commit 5ca9b27
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -24,8 +24,8 @@
   },
   "scripts": {
     "build": "tsc",
-    "lint": "prettier --list-different \"src/**/*.{ts,tsx}\"",
-    "prettier:write": "prettier --write \"src/**/*.{ts,tsx}\"",
+    "lint": "prettier --list-different \"{src,test}/**/*.{ts,tsx}\"",
+    "prettier:write": "prettier --write \"{src,test}/**/*.{ts,tsx}\"",
     "postinstall": "tsc",
     "start": "DEBUG=* probot run ./lib/index.js",
     "test": "vitest run",

diff --git a/src/index.ts b/src/index.ts
@@ -73,13 +73,14 @@ const submitFeedbackForPR = async (
 export const probotRunner = (app: Probot) => {
   app.on('pull_request', async (context) => {
     const pr = context.payload.pull_request;
+    const repo = context.payload.repository.full_name;
 
     if (context.payload.action === 'closed' && pr.merged) {
-      debug(`Checking release notes comment on PR #${pr.number}`);
+      debug(`Checking release notes comment on PR ${repo}#${pr.number}`);
       await submitFeedbackForPR(context, pr, true);
     } else if (!pr.merged && pr.state === 'open') {
       // Only submit feedback for PRs that aren't merged and are open
-      debug(`Checking & posting release notes comment on PR #${pr.number}`);
+      debug(`Checking & posting release notes comment on PR ${repo}#${pr.number}`);
       await submitFeedbackForPR(context, pr);
     }
   });

diff --git a/test/comment.test.ts b/test/comment.test.ts
@@ -48,6 +48,7 @@ describe('probotRunner', () => {
       repository: {
         name: 'electron',
         owner: { login: 'electron' },
+        full_name: 'electron/electron',
       },
     } as PullRequestOpenedEvent;
 
@@ -81,6 +82,11 @@ describe('probotRunner', () => {
           login: 'dependabot[bot]',
         },
       },
+      repository: {
+        name: 'electron',
+        owner: { login: 'electron' },
+        full_name: 'electron/electron',
+      },
     } as PullRequestOpenedEvent;
 
     nock(GH_API)
@@ -109,6 +115,11 @@ describe('probotRunner', () => {
         body: 'Fix something to do with GitHub Actions',
         user: { login: 'codebytere' },
       },
+      repository: {
+        name: 'electron',
+        owner: { login: 'electron' },
+        full_name: 'electron/electron',
+      },
     } as PullRequestOpenedEvent;
 
     nock(GH_API)
@@ -143,6 +154,7 @@ describe('probotRunner', () => {
       repository: {
         name: 'electron',
         owner: { login: 'electron' },
+        full_name: 'electron/electron',
       },
     } as PullRequestOpenedEvent;
 
@@ -182,6 +194,7 @@ describe('probotRunner', () => {
       repository: {
         name: 'electron',
         owner: { login: 'electron' },
+        full_name: 'electron/electron',
       },
     } as PullRequestClosedEvent;