-
Notifications
You must be signed in to change notification settings - Fork 127
Conversation
@hij1nx this is really cool! my only concern is that getting the latest version every time is essentially doing what do you think about making this opt-in, e.g. if you do |
That seems like a valid concern from one perspective. I was under the impression though that this was more of a dev tool than a dependency, so is allowing |
IMO even if it's a devDependency it should still get versioned. It avoids a problem where the code worked when you wrote it and then 6 months later someone tries to get it to run and it breaks |
Well, it's hard to ague that because I agree. What If it defaults to a version but uses a flag to pull latest? |
+1 that seems like a good solution |
Yeah, love this proposal. @mafintosh thoughts? |
I'm all for this. Sorry for being slow. @hij1nx could you resolve the conflict so I can merge this? :) |
var version = '0.19.5' | ||
var name = 'atom-shell-v'+version+'-'+platform+'-'+arch+'.zip' | ||
var url = 'https://github.com/atom/atom-shell/releases/download/v'+version+'/atom-shell-v'+version+'-'+platform+'-'+arch+'.zip' | ||
var arch = (platform == 'win32') ? 'ia32' : os.arch() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var arch = platform === 'win32' ? 'ia32' : os.arch()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform is always a string, so ===
is pointless. parens for readability.
Would also be nice if you could give this pull request a descriptive title. |
lol, just realized this is a dead PR anyway. ffs. |
a quick fix for ensuring that the release downloaded is the latest.