Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Allow configuration of electron version in client package #36

Closed
wants to merge 1 commit into from

Conversation

FWeinb
Copy link

@FWeinb FWeinb commented Jun 8, 2015

This PR includes the following.

  • Upgrade to [email protected]
  • No longer create a path.txt just resolve the path on require. (better portability)
  • Use rc to make it possible to require a custom version of electron
  • documentation

The gist of this is that a client package can create a file .electron-prebuildrc like

{
  "version" : "0.27.0"
}

and electron-prebuild will than install that exact version. In fact, the whole configuration is 1:1 passed to electron-download.

@mafintosh
Copy link
Collaborator

why is the rc file needed? the electron-prebuild versions follow the electron version so to get electron 0.27.0 you just do npm install -g [email protected] and to get the latest one you do npm install -g electron. and you can different versions using regular npm magic :)

@ungoldman
Copy link
Collaborator

I think proper versioning of electron-prebuilt as a dependency in package.json already takes care of this, no?

@FWeinb
Copy link
Author

FWeinb commented Jun 9, 2015

I always have to wait for electron-prebuilt to catch up with electron. This is a good mid term solution until this package is automatically updated.

Am 08.06.2015 um 23:05 schrieb Mathias Buus [email protected]:

why is the rc file needed? the electron-prebuild versions follow the electron version so to get electron 0.27.0 you just do npm install -g [email protected] and to get the latest one you do npm install -g electron. and you can different versions using regular npm magic :)


Reply to this email directly or view it on GitHub.

@max-mapper
Copy link
Contributor

i'd vote to fix the root issue (automatic updates) rather than supporting a workaround

@justinmchase
Copy link

I would vote for this as well, it would be useful for my project electron-updater which will attempt to auto-update electron and therefore needs to know the version.

@max-mapper
Copy link
Contributor

We implemented automatic updates the other day, so now npm will update immediately when a new electron version is released

@max-mapper max-mapper closed this Jun 19, 2015
@justinmchase
Copy link

@maxogden Can you elaborate on that? Documentation or a commit perhaps? I'd be interested to understand what you mean better.

@max-mapper
Copy link
Contributor

@justinmchase heres the issue: #16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants