Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added update script closing #16 #34

Conversation

JamesKyburz
Copy link
Contributor

Bash script updating version.

@max-mapper
Copy link
Contributor

this looks good, im just too busy to test + review at the moment, sorry! other maintainers: feel free

@ingorichter
Copy link
Contributor

does anybody have time to review this? Would be great to get this merged.

@max-mapper
Copy link
Contributor

BTW yesterday we started using this server to handle npm publishing whenever atom/electron does a new GitHub Release https://github.com/johnmuhl/electron-prebuilt-updater/blob/master/index.js

Is this PR still necessary given the functionality of electron-prebuilt-updater?

@JamesKyburz
Copy link
Contributor Author

Cool!! Now that updating install.js isn't needed (because it now uses package.json - which is way better) I think my PR isn't needed.

On 18 jun 2015, at 05:49, maxogden [email protected] wrote:

BTW yesterday we started using this server to handle npm publishing whenever atom/electron does a new GitHub Release https://github.com/johnmuhl/electron-prebuilt-updater/blob/master/index.js

Is this PR still necessary given the functionality of electron-prebuilt-updater?


Reply to this email directly or view it on GitHub.

@max-mapper
Copy link
Contributor

@JamesKyburz thanks for the PR anyway, it got the ball rolling!

@max-mapper max-mapper closed this Jun 19, 2015
@JamesKyburz
Copy link
Contributor Author

@maxogden thx! glad you got it automated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants