fix(msi): manually escape XML special characters when building XML #6878
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project.wxs contains invalid XML chars when building a package containing an ampersand. All attributes are already escaped thanks to EJS engine but the part about files is built as a string and injected as-is in the template. The next step would be to use an EJS template for the files too. electron-userland#5387
👷 Deploy request for car-park-attendant-cleat-11576 pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 18ad378 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project.wxs contains invalid XML chars when building a package
containing an ampersand.
All attributes are already escaped thanks to EJS engine but the part
about files is built as a string and injected as-is in the template.
The next step would be to use an EJS template for the files too.
#5387