-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-builder-lib): bump @electron/universal to 1.2.1 #6750
fix(app-builder-lib): bump @electron/universal to 1.2.1 #6750
Conversation
Currently it cannot build an Electron 18 Universal app
🦋 Changeset detectedLatest commit: 72bc351 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for car-park-attendant-cleat-11576 failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully working
If anyone is having this issue and needs a quick fix until this is merged, you can update your package.json like so:
|
for |
Thank you for your contribution! |
Mostly chromium security updates, and not yet updating to electron 18 as that requires at least electron-builder 23.0.4 (due to electron-userland/electron-builder#6750), but electron-builder 23.0.4+ are not yet stable. Signed-off-by: Christoph Settgast <[email protected]>
This is a prerequisite for universal mac builds with electron 18+ For details see electron-userland/electron-builder#6750
This is a prerequisite for universal mac builds with electron 18+ For details see electron-userland/electron-builder#6750
Mostly chromium security updates, and not yet updating to electron 18 as that requires at least electron-builder 23.0.4 (due to electron-userland/electron-builder#6750), but electron-builder 23.0.4+ are not yet stable. Signed-off-by: Christoph Settgast <[email protected]>
This is a prerequisite for universal mac builds with electron 18+ For details see electron-userland/electron-builder#6750
Currently it cannot build an Electron 18 Universal (Mac) app:
Expected all non-binary files to have identical SHAs when creating a universal build but "Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/MainMenu.nib/keyedobjects-101300.nib"
Universal 1.2.1 has a fix for this, so bumping the version here too.