-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer info about intellij #984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### Importing the project into IntelliJ IDEA | ||
|
||
Rally builds using virtualenv. When importing into IntelliJ you will need to define an appropriate Python SDK, which is provided by virtualenv. | ||
For more details on defining a Python SDK in IntelliJ please refer to their documentation. We recommend using the Python SDK that `make prereq` creates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the existing ES teams info did not include pictures, and I presume its because 1) we need a new folder to store the single pic and 2) that pic is guaranteed to change when intellij shakes up the UI every release. This is why I went with no pics, but I can definitely update the wording a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me then.
CONTRIBUTING.md
Outdated
Rally builds using virtualenv. When importing into IntelliJ you will need to define an appropriate Python SDK, which is provided by virtualenv. | ||
For more details on defining a Python SDK in IntelliJ please refer to their documentation. We recommend using the Python SDK that `make prereq` creates. | ||
|
||
In order to run tests within the IDE, ensure the `Python Integrated Tools` `Default Test Runner` is set to `pytest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python Integrated Tools
/ Testing
/ Default test runner
@dliappis I added a bit more contextual information if you care to review this again, without adding any pictures. No need to review if you feel its ok though. I do see you already approved it. I wont request re-review, but if you see this comment and wish to review, feel free. Otherwise Ill likely merge tomorrow. |
No description provided.