Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign worker-id globally #983

Merged
merged 1 commit into from
May 4, 2020
Merged

Assign worker-id globally #983

merged 1 commit into from
May 4, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we assign the worker id globally instead per load
driver host. This ensures that worker ids are unique even if there is
more than one load driver host.

@danielmitterdorfer
Assing worker-id globally
971545b 
With this commit we assign the worker id globally instead per load
driver host. This ensures that worker ids are unique even if there is
more than one load driver host.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. labels May 4, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.0 milestone May 4, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this May 4, 2020
@dliappis dliappis self-requested a review May 4, 2020 08:12
dliappis
dliappis approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the fix

@danielmitterdorfer danielmitterdorfer changed the title Assing worker-id globally Assign worker-id globally May 4, 2020
@danielmitterdorfer danielmitterdorfer merged commit b422323 into elastic:master May 4, 2020
@danielmitterdorfer danielmitterdorfer deleted the global-worker-id branch May 4, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis