Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass actor system env vars in integration test #972

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we ensure that tox passes environment variables
prefixed with THESPLOG_ that are related to the actor system. This
allows us to configure custom settings for integration tests.

With this commit we ensure that tox passes environment variables
prefixed with `THESPLOG_` that are related to the actor system. This
allows us to configure custom settings for integration tests.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 22, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Apr 22, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Apr 22, 2020
Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielmitterdorfer
Copy link
Member Author

Thanks for the review!

@danielmitterdorfer danielmitterdorfer merged commit e87ca3f into elastic:master Apr 27, 2020
@danielmitterdorfer danielmitterdorfer deleted the pass-thespian-env-vars branch April 27, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants