Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit for all query charts #927

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add a proper unit to all time series charts for
queries.

With this commit we add a proper unit to all time series charts for
queries.
@danielmitterdorfer danielmitterdorfer added the bug Something's wrong label Mar 3, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Mar 3, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 3, 2020
@danielmitterdorfer
Copy link
Member Author

Here's an example chart from our nightlies.

Before:

before

With this PR:

after

Note how the y-axis shows the unit now.

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@danielmitterdorfer danielmitterdorfer merged commit 8b20a97 into elastic:master Mar 5, 2020
@danielmitterdorfer danielmitterdorfer deleted the units-for-q-charts branch March 5, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants