Cleanup Pylint singleton issues #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 16, 2019 14:51
drawlerr
added
the
cleanup
danielmitterdorfer
added
the
:misc
|
@drawlerr can you please:
|
46 tasks
danielmitterdorfer
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Thanks for iterating! LGTM
As I've mentioned yesterday, can you please ensure the following when you merge?
- Reference this PR in all issues mentioned in the checklist in Fix linting issues reported by
make precommit#838 so we know what's fixed by which PR? - Add a
Relates #838in your merge commit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of 1-off pylint warnings that I've fixed and bundled in a single PR for simplicity.
Addressed:
-W1202
-W0706
-W0702
-W0127
-R1723
-R1714
-R1706
-R1702
-E0911
-E0601