Let the runner determine progress #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add the ability to have runners determine progress. Usually the runner is just responsible for executing requests and the parameter source is determining completion. However, there are cases, like snapshot/restore or replication where we need to determine progress based on a request against Elasticsearch.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Oct 14, 2019
| def __init__(self, runnable, name, context_manager_enabled=False): | ||
| def _single_cluster_runner(runnable, name, context_manager_enabled=False): | ||
| # only pass the default ES client | ||
| delegate = DelegatingRunner(runnable, name, lambda es: es["default"], context_manager_enabled) |
tests/driver/driver_test.py
Outdated
| # The runner will determine progress | ||
| "size": None | ||
| }, | ||
| param_source="driver-test-param-source"), |
There was a problem hiding this comment.
nit: indentation seems a bit wonky here
There was a problem hiding this comment.
Thanks! Addressed in b1c5b72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add the ability to have runners determine progress.
Usually the runner is just responsible for executing requests and the
parameter source is determining completion. However, there are cases,
like snapshot/restore or replication where we need to determine progress
based on a request against Elasticsearch.