Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tox environment is clean #766

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Ensure tox environment is clean #766

merged 1 commit into from
Sep 10, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we force-clean the environment used by tox in order to
ensure dependencies are always up-to-date as tox / pip will not upgrade
dependencies automatically.

@danielmitterdorfer
Ensure tox environment is clean
f3a64d7 
With this commit we force-clean the environment used by tox in order to
ensure dependencies are always up-to-date as tox / pip will not upgrade
dependencies automatically.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Sep 10, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Sep 10, 2019
ebadyano
ebadyano approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@danielmitterdorfer danielmitterdorfer merged commit af7b36d into elastic:master Sep 10, 2019
@danielmitterdorfer
Copy link
Member Author

Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer deleted the tox-clean branch September 10, 2019 13:40
novosibman pushed a commit to novosibman/rally that referenced this pull request Oct 2, 2019
@danielmitterdorfer @novosibman
Ensure tox environment is clean
ffd90b8 
With this commit we force-clean the environment used by tox in order to
ensure dependencies are always up-to-date as tox / pip will not upgrade
dependencies automatically.

Relates elastic#766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadyano ebadyano ebadyano approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @ebadyano