Remove MergeParts internal telemetry device #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebadyano
added
:Telemetry
ebadyano
changed the title
ebadyano
changed the title
ebadyano
requested review from
danielmitterdorfer and
dliappis
and removed request for
danielmitterdorfer
There was a problem hiding this comment.
Thanks! The change looks mostly fine but I left a comment around an unused import. As this is a breaking change (we're removing existing functionality), can you please provide a bit more context in the PR description on the consequences (a short summary of what metrics will not be gathered anymore and what will change in the report) so interested users can get more details without needing to go through all of the changes in the PR?
| """ | ||
| Gathers merge parts time statistics. Note that you need to run a track setup which logs these data. | ||
| """ | ||
| MERGE_TIME_LINE = re.compile(r": (\d+) msec to merge ([a-z ]+) \[(\d+) docs\]") |
There was a problem hiding this comment.
This results in (at least) one new unused import re in this module. Can you please check unused imports and remove them?
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Sep 10, 2019
With this commit we remove all merge time related metrics from the command line report as they are not measured anymore since elastic#764. Relates elastic#764
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
Remove the Merge Parts telemetry device, which would display different merge times as reported by Lucene only when Lucene index writer trace logging was enabled (`--car-params="verbose_iw_logging_enabled:true"`). The following metric keys will not be gathered anymore: `merge_parts_total_time_*` where * is one of `postings, stored fields, doc values, norms, vectors, points` Closes elastic#754
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we remove all merge time related metrics from the command line report as they are not measured anymore since elastic#764. Relates elastic#764 Relates elastic#767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Merge Parts telemetry device, which would display different merge times as reported by Lucene only when Lucene index writer trace logging was enabled (
--car-params="verbose_iw_logging_enabled:true"). The following metric keys will not be gathered anymore:merge_parts_total_time_*where * is one ofpostings, stored fields, doc values, norms, vectors, pointsCloses #754