Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register pyenv Python versions #706

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Register pyenv Python versions #706

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3bde12
Register pyenv Python versions
danielmitterdorfer Jun 7, 2019
e4650a4
Extract versions from make-requirements
danielmitterdorfer Jun 7, 2019
3b08b67
Use shell redirect
danielmitterdorfer Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ prereq: make-requirements.txt
pyenv install --skip-existing $(PY37)
# pyenv global system $(PY34) $(PY35) $(PY36) $(PY37)
pyenv global system $(PY35) $(PY36) $(PY37)
@# Ensure all Python versions are registered for this project
@awk -F'=' '{print $$2 > ".python-version"}' make-requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but IMHO it is a bit strange to do a file redirection inside awk for this use case;
would it be simpler to
@awk -F'=' '{print $$2}' make-requirements.txt >.python-version

i.e. redirect the final result of awk to .python-version?

Copy link
Member Author

@danielmitterdorfer danielmitterdorfer Jun 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it now.

-@ printf $(PYENV_PREREQ_HELP)

venv-create:
Expand Down