Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use license instead of dist flavor in charts #684

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Use license instead of dist flavor in charts #684

merged 1 commit into from
Apr 18, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we change the chart generator so it uses the license
instead of the distribution flavor in charts in order to ensure that
charts only show results for the correct license (trial and basic have
the same distribution flavor and would thus be mixed up).

@danielmitterdorfer
Use license instead of dist flavor in charts
2da802f 
With this commit we change the chart generator so it uses the license
instead of the distribution flavor in charts in order to ensure that
charts only show results for the correct license (trial and basic have
the same distribution flavor and would thus be mixed up).
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 18, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.1.0 milestone Apr 18, 2019
ebadyano
ebadyano approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@danielmitterdorfer danielmitterdorfer merged commit 976032b into elastic:master Apr 18, 2019
@danielmitterdorfer danielmitterdorfer deleted the consider-license-in-charts branch April 18, 2019 14:08
dliappis added a commit to dliappis/rally that referenced this pull request Apr 26, 2019
@dliappis
Fix release charts after elastic#684
03bf1e5 
PR elastic#684 is now passing es_license, but this is missing from the
`format_title()` method signature in the BarCharts class.
@dliappis dliappis mentioned this pull request Apr 26, 2019
Merged
dliappis added a commit that referenced this pull request Apr 30, 2019
@dliappis
Fix release charts after
b8ad322 
PR #684 is now passing es_license, but this is missing from the
`format_title()` method signature in the BarCharts class.

Relates #687
@ebadyano ebadyano added :internal Changes for internal, undocumented features: e.g. experimental, release scripts and removed :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadyano ebadyano ebadyano approved these changes

Assignees
No one assigned
Labels
bug Something's wrong :internal Changes for internal, undocumented features: e.g. experimental, release scripts
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @ebadyano