Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make install as default target #594

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add a new make target that installs Rally properly for
development. The make target assumes that a virtual environment is already setup
and activated (which is consistent with our dev documentation).

With this commit we add a new make target that installs Rally properly for
development. The make target assumes that a virtual environment is already setup
and activated (which is consistent with our dev documentation).
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Nov 2, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.0.2 milestone Nov 2, 2018
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit 536e110 into elastic:master Nov 2, 2018
@danielmitterdorfer danielmitterdorfer deleted the make-install branch November 2, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants