Add parameter support to telemetry devices #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new command line flag `--telemetry-params` which allows users to inject parameters to telemetry devices. We also enhance the `jfr` telemetry device to choose the recording template based on such a parameter.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Apr 6, 2018
|
|
||
| java_opts = self.java_opts(log_file) | ||
|
|
||
| logger.info("jfr: Adding JVM arguments: [%s].", java_opts) |
There was a problem hiding this comment.
Could use the new .format() here.
There was a problem hiding this comment.
Ah silly me. It's the logger. Ignore.
There was a problem hiding this comment.
I think this is a different case here and I wanted to discuss this separately anyway. It looks as if we are using old style string formatting but we are actually not. This is the standard way the Python logging facility is used and I think it would make sense that we go with the default here.
There was a problem hiding this comment.
Ok, I'll merge then. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new command line flag
--telemetry-paramswhich allows users to inject parameters to telemetry devices.
We also enhance the
jfrtelemetry device to choose the recordingtemplate based on such a parameter.