Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python faulthandler #434

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we remove the faulthandler code from Rally and all
Rally actors. Originally it was meant to get diagnostic information on
SIGQUIT. However, we can instead use gdb and the py-bt helper in order
to get the same information more reliably.

With this commit we remove the faulthandler code from Rally and all
Rally actors. Originally it was meant to get diagnostic information on
SIGQUIT. However, we can instead use gdb and the py-bt helper in order
to get the same information more reliably.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Mar 9, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.9.4 milestone Mar 9, 2018
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit fabefdd into elastic:master Mar 9, 2018
@danielmitterdorfer danielmitterdorfer deleted the remove-faulthandler branch April 6, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants