Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google-auth to 2.38.0 #1929

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

dpifke-elastic
Copy link
Contributor

@dpifke-elastic dpifke-elastic commented Mar 19, 2025

No description provided.

@dpifke-elastic dpifke-elastic requested a review from a team March 19, 2025 02:30
pyproject.toml Outdated
@@ -76,7 +76,7 @@ dependencies = [
# google-crc32c: Apache 2.0
"google-resumable-media[requests]==1.1.0",
# License: Apache 2.0
"google-auth==1.22.1",
"google-auth==2.17.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we dont go straight to 2.38.0 (released 2025) - 2.17.3 is already almost 2 years old, and from what I can see there arent any breaking changes since 2.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I matched the version to what we're using internally (1.22 was blocking Rally and esbench from being imported together). I'll bump the version here to 2.38.0 and we can upgrade esbench as well.

@dpifke-elastic dpifke-elastic changed the title Upgrade google-auth to 2.17.3 Upgrade google-auth to 2.38.0 Mar 19, 2025
@dpifke-elastic dpifke-elastic merged commit ac48f90 into elastic:master Mar 21, 2025
15 checks passed
@dpifke-elastic dpifke-elastic added cleanup Linter changes, reformatting, removal of unused code etc. dependencies Pull requests that update a dependency file labels Mar 28, 2025
@dpifke-elastic dpifke-elastic added this to the 2.12.0 milestone Mar 28, 2025
@dpifke-elastic dpifke-elastic added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. dependencies Pull requests that update a dependency file :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants