Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying user tags as json #1610

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Nov 3, 2022

While the rest of the cli options (like car-params, telemetry-params) support json, in addition to command separate K:V string, this is currently not possible in Rally.

This commit adds additionaly support for user-specified tags as inlined json or referenced from a json file.

While the rest of the cli options (like `car-params`,
`telemetry-params`) support json, in addition to command separate K:V
string, this is currently not possible in Rally.

This commit adds additionaly support for user-specified tags as inlined
json or referenced from a json file.
@dliappis dliappis added :Usability Makes Rally easier to use tech debt labels Nov 3, 2022
@dliappis dliappis self-assigned this Nov 3, 2022
Copy link
Contributor

@michaelbaamonde michaelbaamonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI. Very nice change!

@dliappis
Copy link
Contributor Author

dliappis commented Nov 3, 2022

@elasticmachine run rally/rally-tracks-compat

@dliappis dliappis merged commit 445f2a0 into elastic:master Nov 3, 2022
@pquentin pquentin added this to the 2.7.1 milestone Mar 2, 2023
@pquentin pquentin added enhancement Improves the status quo and removed tech debt labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants