Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use narrower exception to avoid pylint ignore #1579

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Use narrower exception to avoid pylint ignore #1579

merged 1 commit into from
Sep 26, 2022

Conversation

pquentin
Copy link
Member

getheader() cannot throw an exception and now always returns a string so the only possible exception is ValueError.

This is a small thing I noticed when working on #1578.

@pquentin
Use narrower exception to avoid pylint ignore
75f9cce 
getheader() cannot throw an exception and now always returns a string so
the only possible exception is ValueError.
@pquentin
Copy link
Member Author

@elasticmachine run rally/rally-tracks-compat

@pquentin pquentin requested review from DJRickyB and b-deam September 20, 2022 09:59
@pquentin pquentin self-assigned this Sep 20, 2022
@pquentin pquentin added the cleanup Linter changes, reformatting, removal of unused code etc. label Sep 20, 2022
DJRickyB
DJRickyB approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pquentin pquentin merged commit d97b62b into elastic:master Sep 26, 2022
@pquentin pquentin deleted the narrower-exception branch September 26, 2022 05:20
@pquentin pquentin added this to the 2.7.0 milestone Nov 2, 2022
@pquentin pquentin added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJRickyB DJRickyB DJRickyB approved these changes

@b-deam b-deam Awaiting requested review from b-deam

Assignees

@pquentin pquentin

Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @DJRickyB