Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax target-hosts check for multi clusters #1518

Merged
merged 7 commits into from
Jun 15, 2022
Merged

Relax target-hosts check for multi clusters #1518

merged 7 commits into from
Jun 15, 2022

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jun 15, 2022

This change relaxes the check of the cluster keys of the client_options and target_hosts parameters. These parameters are dictionaries, and their keys can be in any order.

@dnhatn dnhatn added the bug Something's wrong label Jun 15, 2022
inqueue
inqueue reviewed Jun 15, 2022
View reviewed changes
@dnhatn dnhatn requested a review from inqueue June 15, 2022 18:24
inqueue
inqueue approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@inqueue inqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dnhatn
Copy link
Member Author

dnhatn commented Jun 15, 2022

Thanks Jason!

@dnhatn dnhatn merged commit b7648f6 into elastic:master Jun 15, 2022
@dnhatn dnhatn deleted the multi-target-hosts branch June 15, 2022 18:46
@pquentin pquentin added this to the 2.5.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inqueue inqueue inqueue approved these changes

Assignees
No one assigned
Labels
bug Something's wrong
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnhatn @inqueue @pquentin