-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parallel tasks to exit on any completion #1305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left a few suggestions. IMHO also a test for the track loader is missing.
I think I addressed the comments, can you take a look when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating. I left one nit but other than that LGTM. No need for another review round.
With this commit we add the ability to specify a new
any
valuefor the
completed-by
param forparallel
task blocks. Thisallows the
parallel
block to be completed by whichever task isfirst to complete successfully.
Closes #1261
Tested with track: