Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider new API calls in static response example #1267

Merged
merged 2 commits into from
May 25, 2021

Conversation

danielmitterdorfer
Copy link
Member

With this commit we amend the example response file in our documentation
to also include a static response for the cluster settings API. This is
needed because Rally issues this call to determine the value of
action.destructive_requires_name prior to issuing a delete index
request.

Relates #1243

With this commit we amend the example response file in our documentation
to also include a static response for the cluster settings API. This is
needed because Rally issues this call to determine the value of
`action.destructive_requires_name` prior to issuing a delete index
request.

Relates elastic#1243
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Docs Changes to the documentation labels May 19, 2021
@danielmitterdorfer danielmitterdorfer added this to the 2.2.1 milestone May 19, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this May 19, 2021
Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. suggested an optional change for completeness sake (this is what is returned in totality when no custom settings are applied)

@danielmitterdorfer danielmitterdorfer merged commit 0acd50e into elastic:master May 25, 2021
@danielmitterdorfer danielmitterdorfer deleted the static-example branch May 25, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Docs Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants