Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reimporting modules #1080

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Avoid reimporting modules #1080

merged 3 commits into from
Nov 5, 2020

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Oct 7, 2020

With this commit we reenable the pylint check W0404 which checks
whether an import has already been imported.

Relates #838

@hub-cap hub-cap added the cleanup Linter changes, reformatting, removal of unused code etc. label Oct 7, 2020
@hub-cap hub-cap added this to the 2.0.2 milestone Oct 7, 2020
@hub-cap hub-cap requested a review from gingerwizard October 7, 2020 20:57
@hub-cap hub-cap self-assigned this Oct 7, 2020
@hub-cap hub-cap changed the title Fix pylint W0404 Avoid reimporting modules Oct 12, 2020
@danielmitterdorfer danielmitterdorfer modified the milestones: 2.0.2, 2.0.3 Oct 26, 2020
Copy link

@gingerwizard gingerwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hub-cap
Copy link
Contributor Author

hub-cap commented Nov 3, 2020

@elasticmachine update branch

@hub-cap hub-cap merged commit 202314b into elastic:master Nov 5, 2020
@hub-cap hub-cap deleted the lint_W0404 branch November 5, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants