Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint C0121 and W0311 issues #1021

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix lint C0121 and W0311 issues #1021

merged 1 commit into from
Jun 23, 2020

Conversation

ebadyano
Copy link
Contributor

singleton-comparison and bad-indentation

Relates to #838

@ebadyano
Fix lint C0121 and W0311 issues
e1f57b0 
singleton-comparison and bad-indentation

Relates to elastic#838
@ebadyano ebadyano added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. cleanup Linter changes, reformatting, removal of unused code etc. labels Jun 17, 2020
@ebadyano ebadyano added this to the 2.0.1 milestone Jun 17, 2020
@ebadyano ebadyano requested a review from dliappis June 17, 2020 20:43
@ebadyano ebadyano self-assigned this Jun 17, 2020
@dliappis dliappis mentioned this pull request Jun 17, 2020
Closed
46 tasks
dliappis
dliappis requested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for marching through this task!

There are a few issues I spotted with the indentation in the files.
^^ wrong comment was looking at wrong branch! Sorry!

@dliappis dliappis self-requested a review June 18, 2020 17:02
dliappis
dliappis approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadyano ebadyano merged commit 12d7fc3 into elastic:master Jun 23, 2020
@ebadyano ebadyano deleted the C0121-master branch December 16, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@ebadyano ebadyano

Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ebadyano @dliappis