Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for transform API's #1011
add support for transform API's #1011
Changes from 10 commits
6faa39d
4ab0d66
eeaff59
d729e5d
c58e146
9c08cd1
7e73926
834c898
7d2e4ac
47571ed
3729535
0773811
cb75f50
df54fb2
bb25516
bf2fa2e
db7bb7c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to specify the time unit for
poll-interval
? i.e.0.5
(seconds)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, would the poll-interval also affect the performance? Not sure if we want to mention that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it might affect performance, but I can't say how much. It shouldn't be expensive.
FWIW: I debugged the progress reporting and it seems progress isn't working in rally. Is there an existing issue? Is there a plan to fix this? If not, it might be better to remove the progress report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress reporting might be a bit of a trade of
Functions that implement
completed
andpercent_completed
are called until_completed
isn't set to True. The issue is thatexecute-transform
just has a while loop and blocks there until completed is set to True, sopercent_completed
is never updated. For it to work we would need to havestart_transform
outside of theexecute_transform
andexecute_transform
should just checkget_transform_stats
and update_percent_completed
outside of the loop and after the sleep and and once it's done set_completed
to True. In this case it probably should be named something likewait-for-transformation
. And in the track we would need to have both operationsstart_transformation
followed bywait-for-transformation
. We used to have an example of that for snapshot recovery operation, but it got changed to just waiting for the restore to complete in a loop without updatingpercent_completion
to get more accurate throughout and how long it took to complete information as otherwise it could be off by the sleep time. Here is the change 9f73d5d where you can see both how it was before and after. Although i think in your case it should be okay to use percentage completed, since you are relaying on information from get_transform_stats to get the performance..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the explanation! Lets discuss this later, I lean towards keeping
execute-transform
the way it is and rather remove the progress info.