Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support to specify cluster settings in the track #915

Closed
danielmitterdorfer opened this issue Feb 21, 2020 · 2 comments · Fixed by #1238
Closed

Remove support to specify cluster settings in the track #915

danielmitterdorfer opened this issue Feb 21, 2020 · 2 comments · Fixed by #1238
Assignees
@danielmitterdorfer
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch breaking Non-backwards compatible change cleanup Linter changes, reformatting, removal of unused code etc. :Track Management New operations, changes in the track format, track download changes and the like
Milestone
2.2.0

Comments

@danielmitterdorfer
Copy link
Member

So far we allow to specify a cluster-settings element in the track. This is trappy because it only works in certain circumstances, namely when Rally sets up the benchmark candidate itself.

However, as we split Rally's functionality into individual subcommands, this should be done differently:
@danielmitterdorfer danielmitterdorfer added :Track Management New operations, changes in the track format, track download changes and the like :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch breaking Non-backwards compatible change cleanup Linter changes, reformatting, removal of unused code etc. labels Feb 21, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Feb 21, 2020
danielmitterdorfer added a commit to danielmitterdorfer/rally-tracks that referenced this issue Feb 21, 2020
@danielmitterdorfer
Set cluster-settings via API
f903424 
With this commit we avoid the deprecated track property
`cluster-settings` and replace it with an explicit API call.

Relates elastic#93
Relates elastic/rally#831
Relates elastic/rally#915
@danielmitterdorfer danielmitterdorfer mentioned this issue Feb 21, 2020
Merged
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue Feb 21, 2020
@danielmitterdorfer
Set cluster-settings via API (#98)
877a592 
With this commit we avoid the deprecated track property
`cluster-settings` and replace it with an explicit API call.

Relates #93
Relates elastic/rally#831
Relates elastic/rally#915
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue Feb 21, 2020
@danielmitterdorfer
Set cluster-settings via API (#98)
a026a32 
With this commit we avoid the deprecated track property
`cluster-settings` and replace it with an explicit API call.

Relates #93
Relates elastic/rally#831
Relates elastic/rally#915
@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Feb 25, 2020 •
edited
Loading

Note that the geonames track for 2.x and 5.x requires the setting indices.query.bool.max_clause_count to be set when starting the node. We need to change our integration tests accordingly before we can do the actual change in rally-tracks. Otherwise we'd get (with version 5.x):

[ERROR] Cannot race. Error in load generator [0]
	("Request returned an error. Error type: transport, Description: illegal_argument_exception ({'error': {'root_cause': [{'type': 'illegal_argument_exception', 'reason': 'transient setting [indices.query.bool.max_clause_count], not dynamically updateable'}], 'type': 'illegal_argument_exception', 'reason': 'transient setting [indices.query.bool.max_clause_count], not dynamically updateable'}, 'status': 400})", None)

This output has been created with esrally --track=geonames --distribution-version=5.6.16 --test-mode --on-error=abort and elastic/rally-tracks@a026a32.

@danielmitterdorfer danielmitterdorfer modified the milestones: 1.5.0, 1.6.0, 2.0.1, 2.x Apr 29, 2020
@danielmitterdorfer danielmitterdorfer mentioned this issue Nov 4, 2020
Closed
2 tasks
@danielmitterdorfer danielmitterdorfer added the blocked This item cannot be finished because of a dependency label Nov 4, 2020
@danielmitterdorfer
Copy link
Member Author

We should work on this in the context of #1107 when we'll remove support for 5.x

@danielmitterdorfer danielmitterdorfer removed the blocked This item cannot be finished because of a dependency label Apr 12, 2021
@danielmitterdorfer danielmitterdorfer self-assigned this Apr 12, 2021
@danielmitterdorfer danielmitterdorfer modified the milestones: 2.x, 2.2.0 Apr 12, 2021
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Apr 12, 2021
@danielmitterdorfer
Disallow to specify cluster settings in the track
2ac11dc 
With this commit we don't honor the challenge property
`cluster-settings` anymore as this is mixing multiple concerns (cluster
setup and running the benchmark). Instead, we encourage users to use the
`put-settings` API for dynamic cluster settings and the existing
mechanism in rally-teams to inject static cluster settings.

Closes elastic#915
@danielmitterdorfer danielmitterdorfer mentioned this issue Apr 12, 2021
Merged
danielmitterdorfer added a commit that referenced this issue Apr 19, 2021
@danielmitterdorfer
Disallow to specify cluster settings in the track (#1238)
90f031b 
With this commit we don't honor the challenge property
`cluster-settings` anymore as this is mixing multiple concerns (cluster
setup and running the benchmark). Instead, we encourage users to use the
`put-settings` API for dynamic cluster settings and the existing
mechanism in rally-teams to inject static cluster settings.

Closes #915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmitterdorfer danielmitterdorfer

Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch breaking Non-backwards compatible change cleanup Linter changes, reformatting, removal of unused code etc. :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Disallow to specify cluster settings in the track danielmitterdorfer/rally
1 participant
@danielmitterdorfer