Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage development dependencies in setup.py #439

Closed
danielmitterdorfer opened this issue Mar 13, 2018 · 1 comment · Fixed by #788
Closed

Manage development dependencies in setup.py #439

danielmitterdorfer opened this issue Mar 13, 2018 · 1 comment · Fixed by #788
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Milestone
1.4.0

Comments

@danielmitterdorfer
Copy link
Member

Currently maintainers need to install development dependencies manually. However, we can use the extras_require functionality to declare optional dependencies for development in setup.py and simplify development setup for new maintainers (see e.g. https://github.com/elastic/elasticsearch-py/blob/master/setup.py#L66-L68 for an example; use pip install -e .[develop] to install).
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Mar 13, 2018
@danielmitterdorfer danielmitterdorfer added this to the Backlog milestone Apr 12, 2018
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Nov 14, 2018
@danielmitterdorfer
Simplify development setup
344d51c 
With this commit we amend the `make install` command to also include
development dependencies so developers don't need to perform this step
manually when setting up Rally. However, this is only a workaround and
should be properly addressed by elastic#439.

Relates elastic#439
@danielmitterdorfer danielmitterdorfer mentioned this issue Nov 14, 2018
Merged
@danielmitterdorfer
Copy link
Member Author

Note that when addressing this we should also cleanup the workaround implemented in #599.

danielmitterdorfer added a commit that referenced this issue Nov 14, 2018
@danielmitterdorfer
Simplify development setup
1db123c 
With this commit we amend the `make install` command to also include
development dependencies so developers don't need to perform this step
manually when setting up Rally. However, this is only a workaround and
should be properly addressed by #439.

Relates #439 
Relates #599
@danielmitterdorfer danielmitterdorfer modified the milestones: Backlog, 1.4.0 Oct 9, 2019
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Oct 9, 2019
@danielmitterdorfer
Manage dev dependencies in setup.py
4876498 
With this commit we define development dependencies as extra
requirements and set them up in the `make install` target. This
simplifies setup and also removes duplication from our tox
configuration.

Closes elastic#439
@danielmitterdorfer danielmitterdorfer mentioned this issue Oct 9, 2019
Merged
danielmitterdorfer added a commit that referenced this issue Oct 10, 2019
@danielmitterdorfer
Manage dev dependencies in setup.py
ddfca71 
With this commit we define development dependencies as extra
requirements and set them up in the `make install` target. This
simplifies setup and also removes duplication from our tox
configuration.

Closes #439
Relates #788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Manage dev dependencies in setup.py danielmitterdorfer/rally
1 participant
@danielmitterdorfer