Use keyword field for term query and terms agg #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we use the keyword subfield in the `geonames` track for the `term` query and aggregations that aggregate on terms. While the terms aggregation produces correct results on a `text` field, the `term` query does not return any results (which is unintended).
|
Thank you for the review! |
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 13, 2020
With this commit we use the keyword subfield in the `geonames` track for the `term` query and aggregations that aggregate on terms. While the terms aggregation produces correct results on a `text` field, the `term` query does not return any results (which is unintended).
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 13, 2020
With this commit we use the keyword subfield in the `geonames` track for the `term` query and aggregations that aggregate on terms. While the terms aggregation produces correct results on a `text` field, the `term` query does not return any results (which is unintended).
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 13, 2020
With this commit we use the keyword subfield in the `geonames` track for the `term` query and aggregations that aggregate on terms. While the terms aggregation produces correct results on a `text` field, the `term` query does not return any results (which is unintended).
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 13, 2020
With this commit we use the keyword subfield in the `geonames` track for the `term` query and aggregations that aggregate on terms. While the terms aggregation produces correct results on a `text` field, the `term` query does not return any results (which is unintended).
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 13, 2020
With this commit we use the keyword subfield in the `geonames` track for the `term` query and aggregations that aggregate on terms. While the terms aggregation produces correct results on a `text` field, the `term` query does not return any results (which is unintended).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we use the keyword subfield in the
geonamestrack forthe
termquery and aggregations that aggregate on terms. While theterms aggregation produces correct results on a
textfield, thetermquery does not return any results (which is unintended).