Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for transform settings.unattended #491

Merged
merged 1 commit into from
Mar 22, 2023
Merged

add support for transform settings.unattended #491

merged 1 commit into from
Mar 22, 2023

Conversation

joeypoon
Copy link
Member

@joeypoon joeypoon commented Mar 20, 2023 •
edited
Loading

What does this PR do?

This adds support for the transform settings.unattended option.

Why is it important?

We recently added unattended: true into endpoint-package. We were previously managing the health of our transforms manually (kibana task for restarting / reinstalling our package transforms).

Checklist

Related issues

@elasticmachine
Copy link

elasticmachine commented Mar 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T16:33:39.652+0000

  • Duration: 8 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 716
Skipped 0
Total 716

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 20, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 69.231% (18/26) 👍
Classes 77.143% (27/35) 👍
Methods 56.757% (63/111) 👍
Lines 42.727% (564/1320) 👍
Conditionals 100.0% (0/0) 💚

@joeypoon joeypoon marked this pull request as ready for review March 20, 2023 23:00
@joeypoon joeypoon requested a review from a team as a code owner March 20, 2023 23:00
@joeypoon joeypoon force-pushed the chore/transform-unattended branch from d85c2d1 to 5c4712f Compare March 21, 2023 15:38
@joeypoon joeypoon requested a review from jsoriano March 21, 2023 16:28
mrodm
mrodm reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a comment to add also this new field in good_v2.

test/packages/good/elasticsearch/transform/metadata_current/transform.yml Show resolved Hide resolved
@joeypoon joeypoon force-pushed the chore/transform-unattended branch from 5c4712f to 48f4132 Compare March 21, 2023 16:33
mrodm
mrodm approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrodm mrodm merged commit 01f0f74 into main Mar 22, 2023
@mrodm mrodm deleted the chore/transform-unattended branch March 22, 2023 08:09
@jillguyonnet jillguyonnet mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodm mrodm mrodm approved these changes

@jsoriano jsoriano Awaiting requested review from jsoriano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joeypoon @elasticmachine @jsoriano @mrodm