Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Osquery] Add kibana/osquery-pack-asset #299

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Mar 21, 2022

What does this PR do?

Adds support for kibana/osquery-pack-asset

Why is it important?

We want to be able to ship osquery_pack_asset with osquery_manager integration, so the user can start using Osquery with the set of prebuilt packs

Checklist

Related issues

Relates elastic/integrations#2851
Relates elastic/kibana#128109

@patrykkopycinski patrykkopycinski requested a review from a team as a code owner March 21, 2022 09:20
@patrykkopycinski patrykkopycinski self-assigned this Mar 21, 2022
@elasticmachine
Copy link

elasticmachine commented Mar 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-21T09:21:32.313+0000

  • Duration: 2 min 28 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me from the spec perspective, but as long as this change affects Kibana, I'm adding @joshdover as a reviewer.

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes LGTM

@mtojek mtojek self-requested a review March 22, 2022 11:39
@mtojek mtojek merged commit f0dc2f4 into main Mar 22, 2022
@patrykkopycinski patrykkopycinski deleted the feat/add-osquery-pack-asset branch March 22, 2022 11:56
@mtojek mtojek mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants