Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Proposal] Optional NOTICE.txt file for integrations #149

Closed
rw-access opened this issue Mar 16, 2021 · 3 comments · Fixed by #151
Closed

[Change Proposal] Optional NOTICE.txt file for integrations #149

rw-access opened this issue Mar 16, 2021 · 3 comments · Fixed by #151
Labels
discuss Issue needs discussion

Comments

@rw-access
Copy link
Contributor

Related to #142

Some parts of these integrations could included code licensed with permissive licenses (MIT, BSD3, Apache 2, etc.). Even though the final license of all our integrations is Elastic License, Elastic License 2.0 or SSPL, we still have to preserve the original license notices when copying the code or binaries around.

We should have a generic way of including a NOTICE.txt file for each integration and deliver that to Kibana with the rest of the assets.. The most relevant use case currently is the Detection engine rules, which currently copy https://github.com/elastic/detection-rules/blob/main/NOTICE.txt into Kibana in https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules/notice.ts.

@rw-access rw-access added the discuss Issue needs discussion label Mar 16, 2021
@ruflin
Copy link
Collaborator

ruflin commented Mar 17, 2021

From our other projects, I'm used to the NOTICE.txt file on the root level. Should we do the same for the packages to have an option NOTICE.txt file on the root level?

I wonder where in Kibana we should show this? I see you make it available in the detection rules but again I would consider this a generic feature. Maybe on the package view page, a user could click on a link to see it. It would still be possible to also show it on the rules page.

@rw-access
Copy link
Contributor Author

Maybe on the package view page, a user could click on a link to see it.

My thoughts exactly. That checks all the boxes for me.

@ruflin
Copy link
Collaborator

ruflin commented Mar 17, 2021

@rw-access Do you want to open a PR against package-spec directly. There we can pull in @mtojek and @ycombinator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants