Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transform package format #109

Closed
jonathan-buttner opened this issue Jan 19, 2021 · 2 comments
Closed

Refactor transform package format #109

jonathan-buttner opened this issue Jan 19, 2021 · 2 comments

Comments

@jonathan-buttner
Copy link
Contributor

The transform format currently requires a directory and a file: https://github.com/elastic/endpoint-package/tree/master/package/endpoint/elasticsearch/transform/metadata_current

For example the link above requires the directory metadata_current and the actual transform file default.json. This could probably be refactored to only use a file. So the package path would look like:

elasticsearch/transform/metadata_current_blah.json.

@ruflin
Copy link
Collaborator

ruflin commented Jan 20, 2021

++ on cleaning this up. I think it is an onversight that transform contained an additional sub directory. It should be aligned with all the other assets. Would be nice if we find a way to clean this up without having to keep too much legacy code / spec definition.

rw-access pushed a commit to rw-access/package-spec that referenced this issue Mar 23, 2021
* Add sample test packages

* Fix

* Remove _dev

* Fix: formatter

* Trap cleanup
@joshdover
Copy link
Contributor

Transforms now include their associated field list, this is no longer relevant as of #307

@joshdover joshdover closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants