Update Docker docs for v6 #8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Nov 6, 2017
ghost
commented
- Document Docker image "flavours"
- Fix up section hierarchy
- Capture Docker config default
- Warn about default "masking" when replacing logstash.yml
ghost
requested a review
from 
ghost
added
docs/static/docker.asciidoc
Outdated
| The images are available in two different configurations or "flavors". The | ||
| `x-pack` flavor, which is the default, ships with X-Pack features | ||
| pre-installed. The `oss` flavor does not include X-Pack, and contains only | ||
| open-source Logstash. |
There was a problem hiding this comment.
Super nitpicky, but the internal style guide says not to hyphenate "open source."
There was a problem hiding this comment.
Thanks. Super nitpicky is what we do!
|
What is the correct way to get this docs patch into
|
|
There was a broken link in this update, so I've put a fix in commit 9ef86d0 |
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2017
* Update Docker docs for v6 * De-hyphenate "open source" in Docker docs
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2017
* Update Docker docs for v6 * De-hyphenate "open source" in Docker docs
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.